opencti icon indicating copy to clipboard operation
opencti copied to clipboard

consistent uppercase CSV + change 5MB labels to 1 MB as it should be

Open yassine-ouaamou opened this issue 1 year ago • 1 comments

I didn't want to create an issue for such a simple thing. So I changed it. If needed, I can create an issue and attach it.

Proposed changes

  • Consistent uppercase for the word "CSV"
  • Change the label of the max size of a file in a CSV mapper test. The limit is 1MB (5 would be too much). So I changed the label "5MB" to "1MB"

Checklist

  • [x] I consider the submitted work as finished
  • [x] I tested the code for its functionality
  • [ ] I wrote test cases for the relevant uses case
  • [ ] I added/update the relevant documentation (either on github or on notion)
  • [ ] Where necessary I refactored code to improve the overall quality

yassine-ouaamou avatar Mar 02 '24 19:03 yassine-ouaamou

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.90%. Comparing base (f0c79df) to head (eb8fd37). Report is 51 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6243      +/-   ##
==========================================
+ Coverage   66.68%   66.90%   +0.21%     
==========================================
  Files         540      541       +1     
  Lines       64349    64413      +64     
  Branches     5251     5400     +149     
==========================================
+ Hits        42912    43096     +184     
+ Misses      21437    21317     -120     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 02 '24 20:03 codecov[bot]