opencti icon indicating copy to clipboard operation
opencti copied to clipboard

Replace Apollo GraphQL packages with @apollo/server 4.0.0

Open renovate[bot] opened this issue 2 years ago • 6 comments

Mend Renovate

This PR contains the following updates:

Package Type Update Change
apollo-server-core (source) dependencies replacement 3.13.0 -> 4.0.0
apollo-server-express (source) dependencies replacement 3.13.0 -> 4.0.0

This is a special PR that replaces apollo-server-core with the community suggested minimal stable replacement version.

This is a special PR that replaces apollo-server-express with the community suggested minimal stable replacement version.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • [ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

renovate[bot] avatar Jan 17 '24 21:01 renovate[bot]

@Kedae re-open this one for visibility. Migrate to Apollo 4 is not an option, it is mandatory in short term.

SamuelHassine avatar Jan 17 '24 21:01 SamuelHassine

@SamuelHassine It already has been plan in the roadmap to be handled

Kedae avatar Jan 24 '24 10:01 Kedae

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

renovate[bot] avatar Jan 31 '24 09:01 renovate[bot]

I pushed my all modifications in the branch. From what I recall there was some issues on subscriptions and on tests.

Kedae avatar Jan 31 '24 09:01 Kedae

Points of attention with these migrations:

  • the graphql subscription
  • the error message format

Archidoit avatar Jun 06 '24 09:06 Archidoit

Linked issues: https://github.com/OpenCTI-Platform/opencti/issues/3991 https://github.com/OpenCTI-Platform/opencti/issues/3990

Archidoit avatar Jun 06 '24 09:06 Archidoit

Codecov Report

Attention: Patch coverage is 11.71875% with 113 lines in your changes missing coverage. Please review.

Project coverage is 67.96%. Comparing base (31c06f3) to head (7473c8b). Report is 1 commits behind head on master.

Files Patch % Lines
...ti-platform/opencti-graphql/src/http/httpServer.js 0.00% 68 Missing :warning:
...ti-platform/opencti-graphql/src/graphql/graphql.js 0.00% 11 Missing :warning:
...cti-platform/opencti-graphql/src/graphql/schema.js 33.33% 6 Missing :warning:
...hql/src/connector/importCsv/importCsv-connector.ts 0.00% 2 Missing :warning:
...-platform/opencti-graphql/src/http/httpPlatform.js 0.00% 2 Missing :warning:
...rm/opencti-graphql/src/manager/fileIndexManager.ts 0.00% 2 Missing :warning:
...tform/opencti-graphql/src/manager/managerModule.ts 0.00% 2 Missing :warning:
...opencti-graphql/src/manager/notificationManager.ts 0.00% 2 Missing :warning:
.../modules/deleteOperation/deleteOperation-domain.ts 0.00% 2 Missing :warning:
...tform/opencti-graphql/src/database/data-builder.js 50.00% 1 Missing :warning:
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5574      +/-   ##
==========================================
+ Coverage   67.83%   67.96%   +0.12%     
==========================================
  Files         572      572              
  Lines       70910    70999      +89     
  Branches     6048     6123      +75     
==========================================
+ Hits        48104    48254     +150     
+ Misses      22806    22745      -61     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 31 '24 15:07 codecov[bot]