opencti icon indicating copy to clipboard operation
opencti copied to clipboard

[frontend/backend] SSH key open vocab in Observable forms (#13656)

Open Archidoit opened this issue 2 months ago • 1 comments

Proposed changes

  • SSH key type in observable creation and edition forms should be a dropdown with the key_type_ov vocabulary values
  • StixCyberObservableDetails to tsx

Related issues

#13656

Archidoit avatar Dec 12 '25 10:12 Archidoit

Codecov Report

:x: Patch coverage is 3.79747% with 76 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 30.67%. Comparing base (26a4bae) to head (d88fd10). :warning: Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...x_cyber_observables/StixCyberObservableDetails.tsx 0.00% 67 Missing :warning:
...rc/utils/hooks/useAttributeValueToReadableValue.ts 0.00% 9 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13658      +/-   ##
==========================================
+ Coverage   30.65%   30.67%   +0.02%     
==========================================
  Files        2906     2907       +1     
  Lines      192005   192034      +29     
  Branches    39088    39189     +101     
==========================================
+ Hits        58851    58899      +48     
+ Misses     133154   133135      -19     
Flag Coverage Δ
opencti 30.67% <3.79%> (+0.02%) :arrow_up:
opencti-front 2.47% <0.00%> (-0.01%) :arrow_down:
opencti-graphql 67.90% <100.00%> (+0.04%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 12 '25 11:12 codecov[bot]

Other than my questions and remarks, everything is great :D ✅

SarahBocognano avatar Dec 15 '25 09:12 SarahBocognano

Yes @SarahBocognano & @Archidoit : if we could add the following key types also by default in platforms, it would be great.

RSA DSA ECDSA EdDSA

nino-filigran avatar Dec 15 '25 09:12 nino-filigran

Yes @SarahBocognano & @Archidoit : if we could add the following key types also by default in platforms, it would be great.

RSA DSA ECDSA EdDSA

@nino-filigran It's strange, there is already a migration for that... It has not been played well ? (migration name: add-vocabulary-ssh-key-type)

written by @CelineSebe do you have more info ?

Archidoit avatar Dec 15 '25 10:12 Archidoit

Yes @SarahBocognano & @Archidoit : if we could add the following key types also by default in platforms, it would be great. RSA DSA ECDSA EdDSA

@nino-filigran It's strange, there is already a migration for that... It has not been played well ? (migration name: add-vocabulary-ssh-key-type)

written by @CelineSebe do you have more info ?

Was there a problem with this migration? The key types are not added when I look at testing in Vocabularies (except 'rsa'). We have an issue with the key_type too @nino-filigran ? image image

CelineSebe avatar Dec 15 '25 11:12 CelineSebe

Yes @SarahBocognano & @Archidoit : if we could add the following key types also by default in platforms, it would be great. RSA DSA ECDSA EdDSA

@nino-filigran It's strange, there is already a migration for that... It has not been played well ? (migration name: add-vocabulary-ssh-key-type) written by @CelineSebe do you have more info ?

Was there a problem with this migration? The key types are not added when I look at testing in Vocabularies (except 'rsa'). We have an issue with the key_type too @nino-filigran ? image image

If I upgrade the migration number and the migration is re-run, the vocabularies are well created... maybe a problem with the migration number in our instances?

Archidoit avatar Dec 15 '25 13:12 Archidoit

If I upgrade the migration number and the migration is re-run, the vocabularies are well created... maybe a problem with the migration number in our instances?

Yes, it's a migration number issue, for sure!

CelineSebe avatar Dec 15 '25 13:12 CelineSebe

LEt's go with (for sake of clarity) : image

nino-filigran avatar Dec 15 '25 14:12 nino-filigran