opencti
opencti copied to clipboard
[backend] Rework enrich connector component for playbooks
Proposed changes
- Rework the enrich connector component for playbooks to be able to merge bundle objects when same ids but different values
- Add previous objects to new bundle if enrichment returns a new object
Related issues
- https://github.com/OpenCTI-Platform/opencti/issues/6669
Checklist
- [x] I consider the submitted work as finished
- [x] I tested the code for its functionality
- [x] I wrote test cases for the relevant uses case (coverage and e2e)
- [x] I added/update the relevant documentation (either on github or on notion)
- [x] Where necessary I refactored code to improve the overall quality
Further comments
Codecov Report
:x: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 16.97%. Comparing base (334e6e2) to head (eb02ee7).
:warning: Report is 5 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...raphql/src/modules/playbook/playbook-components.ts | 89.47% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #13642 +/- ##
==========================================
+ Coverage 16.94% 16.97% +0.02%
==========================================
Files 2934 2934
Lines 146824 146840 +16
Branches 38419 38423 +4
==========================================
+ Hits 24885 24928 +43
+ Misses 121939 121912 -27
| Flag | Coverage Δ | |
|---|---|---|
| opencti | 16.97% <89.47%> (+0.02%) |
:arrow_up: |
| opencti-front | 2.40% <ø> (+<0.01%) |
:arrow_up: |
| opencti-graphql | 59.27% <89.47%> (+0.07%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.