opencti icon indicating copy to clipboard operation
opencti copied to clipboard

[backend] Redis hostname field should not be used when using cluster mode (#6280)

Open aHenryJard opened this issue 7 months ago • 1 comments

Proposed changes

  • Remove "hostname" field as mandatory on SSL configuration for cluster mode (it's "hostnames" that is mandatory in that mode)

Related issues

  • fixes #6280

Checklist

  • [x] I consider the submitted work as finished
  • [x] I tested the code for its functionality
  • [x] I wrote test cases for the relevant uses case (coverage and e2e)
  • [ ] I added/update the relevant documentation (either on github or on notion)
  • [ ] Where necessary I refactored code to improve the overall quality

Further comments

aHenryJard avatar May 13 '25 08:05 aHenryJard

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 65.64%. Comparing base (8bbf3e8) to head (778694f). :warning: Report is 927 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10978      +/-   ##
==========================================
+ Coverage   65.60%   65.64%   +0.04%     
==========================================
  Files         674      674              
  Lines       67138    67144       +6     
  Branches     7415     7421       +6     
==========================================
+ Hits        44046    44077      +31     
+ Misses      23092    23067      -25     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 13 '25 08:05 codecov[bot]

I can't find the time and we may change redis dependency soon. I'm closing.

aHenryJard avatar Oct 09 '25 11:10 aHenryJard