opencti icon indicating copy to clipboard operation
opencti copied to clipboard

[frontend] Display all filters inline with a single tooltip(#9806)

Open CelineSebe opened this issue 10 months ago • 5 comments

Proposed changes

  • one tooltip
  • refacto filterIconButtonContainer

Related issues

  • #9806

Checklist

  • [x] I consider the submitted work as finished
  • [x] I tested the code for its functionality
  • [ ] I wrote test cases for the relevant uses case (coverage and e2e)
  • [ ] I added/update the relevant documentation (either on github or on notion)
  • [ ] Where necessary I refactored code to improve the overall quality

Further comments

CelineSebe avatar Apr 16 '25 08:04 CelineSebe

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.65%. Comparing base (8574c35) to head (7ba9195). Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10694   +/-   ##
=======================================
  Coverage   65.64%   65.65%           
=======================================
  Files         674      674           
  Lines       67198    67198           
  Branches     7420     7426    +6     
=======================================
+ Hits        44114    44116    +2     
+ Misses      23084    23082    -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Apr 17 '25 14:04 codecov[bot]

The tooltip doesn't take the global mode into account

image

--> same tooltip for these two filters whereas they are different (see global mode: and/or)

Archidoit avatar May 07 '25 12:05 Archidoit

The tooltip is poping when I modify filters in entities list : image

Archidoit avatar May 07 '25 12:05 Archidoit

In trigger creation form, the tooltip is displayed at the middle of the form instead of near the filter : image

And it could block the filter edition: image

--> Same in an entity Knowledge tab : image

Archidoit avatar May 19 '25 08:05 Archidoit

When I edit a filter, there should be no tooltip. Example, in this case, it avoids changing the operator: image

image

Archidoit avatar May 19 '25 08:05 Archidoit