openbeta-graphql icon indicating copy to clipboard operation
openbeta-graphql copied to clipboard

Structured data for `attemptType`

Open CocoisBuggy opened this issue 1 year ago • 7 comments

There has been some confusion about what data exactly to put in this field, and it would benefit us in the long-run to constrain this field for data aggregation purposes.

  • [ ] Add an enumeration with reasonable attemptTypes
  • [ ] Allow for some array of these attemptTypes to be assigned to a given tick - There is some philosophizing to be done on this point, but realistically you can have some of these types happen in conjunction.
  • [ ] Allow fetching of the enum from the database - This will be a changing set, so we shouldn't hard-code values accross the various services.

CocoisBuggy avatar Nov 10 '24 17:11 CocoisBuggy

This should also apply to tick styles. Both should be an enum

Vichy97 avatar Nov 11 '24 15:11 Vichy97

For what it's worth, a tick style doesn't seem to be relevant in a bouldering context. The field should be hidden in front-end, and if not already done so, the backend should allow null as an acceptable value (related; #419)

There are additional restrictions one can add (e.g. does the submitted style and attempt type combination make sense?), so things like Boulder/Pinkpoint are not allowed, but I think that might be overkill.

julianlam avatar Nov 12 '24 17:11 julianlam

Copying @Vichy97 comment from Discord

style: only applicable to roped climbs. Possible values:

  • solo
  • tr
  • follow
  • lead

attempt: Only applicable to boulders or roped climbs with "lead" style Possible values for roped climbs

  • attempt
  • redpoint
  • pinkpoint
  • flash
  • onsight

Possible values for boulders

  • attempt
  • send
  • flash

anything that does not fall into these categories should throw an error

--

  • Question: For roped climbs is attempt the same as hangdogging?
  • Todo: we need to support style field

vnugent avatar Nov 30 '24 03:11 vnugent

Ya I think attempt can represent Hung/Fell. The client can display this differently than it is recorded in the backend. Also we do have a style field, it just doesn't get imported from MP correctly

Vichy97 avatar Nov 30 '24 23:11 Vichy97

For lead style should we make it clear whether it's a free attempt or it's aid/french-free

vnugent avatar Dec 04 '24 04:12 vnugent

Hi, is anyone actively working on this? Just want to make sure I'm not duplicating work. I'm new here and this seems like a reasonable "good first issue".

PrithipalKhalsa avatar Jan 20 '25 02:01 PrithipalKhalsa

@PrithipalKhalsa I don't think anyone is working on this right now, it may well be a reasonable first issue. Let me know if you need a hand with getting up and running

CocoisBuggy avatar Jan 20 '25 08:01 CocoisBuggy