openbazaar-desktop icon indicating copy to clipboard operation
openbazaar-desktop copied to clipboard

Published 20 hours ago • verified publisher icon OpenBazaar

Various mod improvements

Open jjeffryes opened this issue 5 years ago • 7 comments

This adds the same changes from #1859 and #1861 to the eth-master branch.

This also closes #1862.

This is built on top of #1863, and should not be merged until that branch is merged. The WIP label is just there to make sure that doesn't happen.

jjeffryes avatar Jan 17 '20 19:01 jjeffryes

@jjeffryes Would you mind updating this with the latest eth-master (I merged #1863) so the change-set is a little lighter?

rmisio avatar Jan 30 '20 22:01 rmisio

@rmisio I merged in eth-master, it's a lot more sane now. :)

jjeffryes avatar Jan 31 '20 20:01 jjeffryes

When I search for a mod, I get double "loading" texts:

image

rmisio avatar Feb 03 '20 23:02 rmisio

@jjeffryes One other thing I noticed is that it appears that when I toggle the Verified Moderators checkbox the whole payment screen is re-rendering. I haven't looked in the code, but I'm basing that on the fact that the images across the whole view flicker.

If that's the case, seems way too heavy handed. I would think that upon toggle just the moderators view would need some state updated.

Anyhow, I know that probably wasn't introduced in this PR, so let me know if it's better I just log an issue we could prioritize for some other time?

rmisio avatar Feb 04 '20 19:02 rmisio

@jjeffryes Also please let me know if I should log a seperate issue for this or if you want to fix it in this PR:

https://github.com/OpenBazaar/openbazaar-desktop/issues/1862#issuecomment-581659203

rmisio avatar Feb 04 '20 19:02 rmisio

@jjeffryes One other thing I noticed is that it appears that when I toggle the Verified Moderators checkbox the whole payment screen is re-rendering. I haven't looked in the code, but I'm basing that on the fact that the images across the whole view flicker.

If that's the case, seems way too heavy handed. I would think that upon toggle just the moderators view would need some state updated.

Anyhow, I know that probably wasn't introduced in this PR, so let me know if it's better I just log an issue we could prioritize for some other time?

I'll see if I can fix that with a reasonable amount of effort when revising this PR, if not I'll create a new issue for it.

jjeffryes avatar Feb 04 '20 19:02 jjeffryes

I made a separate issue for future rendering optimization. https://github.com/OpenBazaar/openbazaar-desktop/issues/1866

The rest of this should be ready for re-review.

jjeffryes avatar Feb 06 '20 21:02 jjeffryes