openbazaar-desktop icon indicating copy to clipboard operation
openbazaar-desktop copied to clipboard

Loading text doesn't go away when searching for mods by peerId

Open rmisio opened this issue 5 years ago • 2 comments

This was tested against the refactorModLoading branch.

Steps to reproduce:

  • In Settings > Store, search for a mod by peerId
  • When the mod loads, click Find to search for the same mod.

Observed: Loading moderator 1 of 1 is shown and never goes away.

image

Expectations:

  • Perhaps Loading moderator 1 of 1 shows briefly or not at all, but it doesn't stay perpetually.

Similar issue:

Steps to reproduce:

  • In Settings > Store, search for a valid Mod by peerId and wait until the mod loads.
  • Search for a non-existent peer by peerId (the peerId should be a valid multihash, just not map to a reachable OB node)

Observed: An error message is shown indicating the node was not reached and Loading moderator 1 of 1 is shown and never goes away.

image

Expectations:

  • Loading moderator 1 of 1 disappears after it's determined the peerId was not found and the error message is shown.

rmisio avatar Jan 15 '20 20:01 rmisio

@jjeffryes The second part of this issue (under the Similar issue: text) is still an issue. Should I break that out into a seperate issue that you could circle back to at some later time?

rmisio avatar Feb 03 '20 22:02 rmisio

@jjeffryes The second part of this issue (under the Similar issue: text) is still an issue. Should I break that out into a seperate issue that you could circle back to at some later time?

I'll tackle that as part of this.

jjeffryes avatar Feb 04 '20 19:02 jjeffryes