historical data for cost to borrow using stocksera api #1300

[guanquann]

Description

• [x] Summary of the change / bug fix.
• [x] Link # issue, if applicable.
• [ ] Screenshot of the feature or the bug before/after fix, if applicable.
• [ ] Relevant motivation and context.
• [x] List any dependencies that are required for this change.

How has this been tested?

• Please describe the tests that you ran to verify your changes.
• Provide instructions so we can reproduce.
• Please also list any relevant details for your test configuration.

Checklist:

• [ ] Update our Hugo documentation following these guidelines.
• [x] Update our tests following these guidelines.
• [x] Make sure you are following our CONTRIBUTING guidelines.
• [x] If a feature was added make sure to add it to the corresponding scripts file.

Others

• [x] I have performed a self-review of my own code.
• [x] I have commented my code, particularly in hard-to-understand areas.
• [x] My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
• [x] New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

[guanquann]

Hey @guanquann,

Thanks for this! Could you add your key to our keys_controller menu so that we can set it directly from the terminal without need to play with files outside that?

In addition, is there any reason why stocksera is set as default? Usually I set as default a data source that doesn't need an API key, UNLESS the quality of the data is better or so. What's the reasoning here?

Oops I didn't know the convention for default data source. Just feel that historical cost to borrow of a specific stock is better than the current cost of borrow of all stocks

edit: i'll updated the code already. let me know how it goes

[colin99d]

@DidierRLopes what are we planning on doing with this PR?

[DidierRLopes]

@DidierRLopes what are we planning on doing with this PR?

What's the time expected to fix the issues and merge it?

[colin99d]

Not sure but I can take lead on it. I am going to start a new PR because this has so many conflicts.