OpenBB icon indicating copy to clipboard operation
OpenBB copied to clipboard

feat(sec): add fiscal period filter for SEC company concepts

Open dijonkitchen opened this issue 1 year ago • 1 comments

Pull Request the OpenBB Platform

Description

Resolves part of https://github.com/OpenBB-finance/OpenBB/issues/6654#issuecomment-2366920407

Allows for SEC company concepts to be filtered by fiscal period.

  • [x] Summary of the change/ bug fix.
  • [x] Link # issue, if applicable.
  • [ ] Screenshot of the feature or the bug before/after fix, if applicable.
  • [x] Relevant motivation and context.
  • [x] List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.

  • Please provide instructions so we can reproduce.

  • Please also list any relevant details for your test configuration.

  • [ ] Ensure all unit and integration tests pass.

  • If you modified/added command(s):

    • [ ] Ensure the command(s) execute with the expected output.
      • [ ] API.
      • [ ] Python Interface.
    • [ ] If applicable, please add new tests for the command (see CONTRIBUTING.md to leverage semi-automated testing).

- If a new provider was introduced or a new fetcher was added to an existing provider: - [ ] Ensure the existing tests pass. - [ ] Ensure the new provider and/or fetcher is stable and usable. - [ ] If applicable, please add new tests for the provider and/or fetcher (see [CONTRIBUTING.md](/openbb_platform/CONTRIBUTING.md) to leverage semi-automated testing). - If a new provider or extension was added: - [ ] Update the list of [Extensions](/openbb_platform/EXTENSIONS.md). - [ ] Update the list of [Providers](/openbb_platform/PROVIDERS.md). - [ ] If it's a community extension or provider, update the [integration tests GitHub Action workflow](/.github/workflows/platform-api-integration-test.yml).

Checklist

  • [ ] I have performed a self-review of my own code.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have adhered to the GitFlow naming convention and my branch name is in the format of feature/feature-name or hotfix/hotfix-name.
  • [ ] I ensure that I am following the CONTRIBUTING guidelines.
    • [ ] (If applicable) I have updated tests following these guidelines.

dijonkitchen avatar Sep 22 '24 19:09 dijonkitchen

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 22 '24 19:09 CLAassistant