OpenBB icon indicating copy to clipboard operation
OpenBB copied to clipboard

Sync with hub on reset + routines fixes

Open montezdesousa opened this issue 2 years ago • 1 comments

  • Syncs terminal with hub when reset
  • Silences routines download
  • Fixes https://github.com/OpenBB-finance/OpenBBTerminal/issues/4841
  • Fixes https://github.com/OpenBB-finance/OpenBBTerminal/issues/4846

I'm building an installer from this to test installer related issues https://github.com/OpenBB-finance/OpenBBTerminal/actions/runs/4756972022

@hjoaquim can you confirm this doesn't break anything on the logs? Its basically reverting to where we were before https://github.com/OpenBB-finance/OpenBBTerminal/pull/4813, but keeping the session if remember is 'n'

montezdesousa avatar Apr 20 '23 15:04 montezdesousa

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@7b77891). Click here to learn what that means. Patch has no changes to coverable lines.

:exclamation: Current head f8a70a9 differs from pull request most recent head c0654c5. Consider uploading reports for the commit c0654c5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4842   +/-   ##
==========================================
  Coverage           ?   58.43%           
==========================================
  Files              ?      588           
  Lines              ?    53610           
  Branches           ?        0           
==========================================
  Hits               ?    31328           
  Misses             ?    22282           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Apr 20 '23 16:04 codecov[bot]

@montezdesousa reset causes the same issue as described here: https://github.com/OpenBB-finance/OpenBBTerminal/issues/4800 - but this might be a thing for another PR, since it was not caused by this one!

hjoaquim avatar Apr 21 '23 08:04 hjoaquim

@montezdesousa is this a build based on this branch: https://github.com/OpenBB-finance/OpenBBTerminal/actions/runs/4760367861 ?

hjoaquim avatar Apr 21 '23 08:04 hjoaquim

@montezdesousa is this a build based on this branch: https://github.com/OpenBB-finance/OpenBBTerminal/actions/runs/4760367861 ?

Yes

montezdesousa avatar Apr 21 '23 08:04 montezdesousa