Fixed default routines message and evident display

[dot-agi]

Description

Fixes #4794. Modified code to display default routines only when personal routines are not found. Added message if personal routines are found and displayed.

Screenshots

[montezdesousa]

Hi, thanks for contributing.

IIUC your solution, after the first personal routine is created, list command would never display default routines again? A better solution might be to add --type argument where user can specify personal or default, so it mimics the hub experience where users have two tabs to check both at any time.

[dot-agi]

Thanks for the review. It sounds like a good idea. We can set the --type to personal by default. So it will work as intended.

I do have a question: what if the user wants to disable displaying the default routines? How do we achieve that?

[montezdesousa]

Thanks for the review. It sounds like a good idea. We can set the --type to personal by default. So it will work as intended.

I do have a question: what if the user wants to disable displaying the default routines? How do we achieve that?

Taking https://my.openbb.dev/app/terminal/routines as reference.

--type personal is the default and we display a message if no routines --type defaults can be accessed explicitly (maybe defaults is not the best naming, we can check that part later and make the website consistent)

[dot-agi]

I see. I will modify the code later to reflect this suggestion. Thanks for the information!

[montezdesousa]

Thanks for the contribution, this also fixes https://github.com/OpenBB-finance/OpenBBTerminal/issues/4803

[codecov[bot]]

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@a787ed2). Click here to learn what that means. Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop    #4798   +/-   ##
==========================================
  Coverage           ?   58.43%           
==========================================
  Files              ?      586           
  Lines              ?    53578           
  Branches           ?        0           
==========================================
  Hits               ?    31307           
  Misses             ?    22271           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.