OpenBB icon indicating copy to clipboard operation
OpenBB copied to clipboard

[IMPROVE] Plotly improvement suggestions

Open JerBouma opened this issue 2 years ago • 4 comments

Given that we have legends, we don't need to put the label in the point floater as well. It gets cutoff anyways and you can't read any of it.

image

Also note the mistake within economy/macro here where it says the unemployment in both the legend and title. It also no longer specifies the units. This could be resolved with setting y-axis label based on the parameter.

About buttons:

  • The downloads of plots shouldn't be happening in the current location, this needs to be done in the OpenBBUserData folder.
  • The text when exporting the image is wrong "Fished downloading to " and is missing the location.
  • The download raw data button does nothing for me.
  • What does "Upload Image" do?

JerBouma avatar Mar 02 '23 14:03 JerBouma

How's this? image

Since we're downloading the plot inside of pywry window which is a web browser it handles the path. If you do --export png it downloads to the OpenBBUserData folder.

Mmmm that's weird for me that print shows the path image

Can you set DEBUG_MODE=True env and see what pywry backend prints?

tehcoderer avatar Mar 02 '23 19:03 tehcoderer

Building a pywry update that will take care of download path inside the browser 👍

image

tehcoderer avatar Mar 02 '23 20:03 tehcoderer

@tehcoderer

I see no reason to include the label in the ticks as we have a legend for that (that's always included). I'd really suggest getting rid of it as it doesn't add value.

And awesome! Make sure that this work for both the raw data exports and plot exports. People will otherwise not be able to find the files.

JerBouma avatar Mar 03 '23 09:03 JerBouma

@JerBouma already merged no labelsss 😉

the raw data and exports path remained unchanged, when inside of the window was the tricky one lol.

Pull dev and pip install pywry -U --force-reinstall

tehcoderer avatar Mar 03 '23 14:03 tehcoderer