OpenBB icon indicating copy to clipboard operation
OpenBB copied to clipboard
Published 3 months ago • verified publisher icon OpenBB-finance

Add tweet news in terminal toolbar

Open DidierRLopes opened this issue 3 years ago • 6 comments

Let me know if there's anything else you want me to do!

Screenshot 2022-12-08 at 22 40 39

DidierRLopes avatar Dec 11 '22 14:12 DidierRLopes

Same thing is happening to me that was happening on the mstarpy branch.

Package operations: 2 installs, 80 updates, 2 removals

  • Removing setuptools (65.4.1)
  • Removing wheel (0.38.4)

@Chavithra @piiq Do we need to add setuptools to poetry?

Although running poetry install breaks stuff

• Updating regex (2022.3.2 -> 2022.10.31): Installing...
  • Updating widgetsnbextension (4.0.3 -> 4.0.4): Failed

  EnvCommandError

  Command ['/Users/james/miniconda3/envs/obb/bin/pip', 'install', '--no-deps', '-U', '/Users/james/Library/Caches/pypoetry/artifacts/62/09/cd/274e73ad1110ae9cc381f10e793ccd028c87c6f098e13c443ebcdc25c2/widgetsnbextension-4.0.4-py3-none-any.whl'] errored with the following return code 2, and output: 
  ERROR: Exception:
  Traceback (most recent call last):
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 160, in exc_logging_wrapper
      status = run_func(*args)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 247, in wrapper
      return func(self, options, args)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/commands/install.py", line 326, in run
      session = self.get_default_session(options)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 98, in get_default_session
      self._session = self.enter_context(self._build_session(options))
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 125, in _build_session
      session = PipSession(
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/network/session.py", line 343, in __init__
      self.headers["User-Agent"] = user_agent()
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/network/session.py", line 175, in user_agent
      setuptools_dist = get_default_environment().get_distribution("setuptools")
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/__init__.py", line 75, in get_default_environment
      return select_backend().Environment.default()
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/__init__.py", line 63, in select_backend
      from . import pkg_resources
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/pkg_resources.py", line 8, in <module>
      from pip._vendor import pkg_resources
  • Updating widgetsnbextension (4.0.3 -> 4.0.4): Failed

  EnvCommandError

  Command ['/Users/james/miniconda3/envs/obb/bin/pip', 'install', '--no-deps', '-U', '/Users/james/Library/Caches/pypoetry/artifacts/62/09/cd/274e73ad1110ae9cc381f10e793ccd028c87c6f098e13c443ebcdc25c2/widgetsnbextension-4.0.4-py3-none-any.whl'] errored with the following return code 2, and output: 
  ERROR: Exception:
  Traceback (most recent call last):
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 160, in exc_logging_wrapper
      status = run_func(*args)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 247, in wrapper
      return func(self, options, args)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/commands/install.py", line 326, in run
      session = self.get_default_session(options)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 98, in get_default_session
      self._session = self.enter_context(self._build_session(options))
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 125, in _build_session
      session = PipSession(
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/network/session.py", line 343, in __init__
      self.headers["User-Agent"] = user_agent()
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/network/session.py", line 175, in user_agent
      setuptools_dist = get_default_environment().get_distribution("setuptools")
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/__init__.py", line 75, in get_default_environment
      return select_backend().Environment.default()
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/__init__.py", line 63, in select_backend
      from . import pkg_resources
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/pkg_resources.py", line 8, in <module>
      from pip._vendor import pkg_resources
  • Updating regex (2022.3.2 -> 2022.10.31)
  • Updating widgetsnbextension (4.0.3 -> 4.0.4): Failed

  EnvCommandError

  Command ['/Users/james/miniconda3/envs/obb/bin/pip', 'install', '--no-deps', '-U', '/Users/james/Library/Caches/pypoetry/artifacts/62/09/cd/274e73ad1110ae9cc381f10e793ccd028c87c6f098e13c443ebcdc25c2/widgetsnbextension-4.0.4-py3-none-any.whl'] errored with the following return code 2, and output: 
  ERROR: Exception:
  Traceback (most recent call last):
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 160, in exc_logging_wrapper
      status = run_func(*args)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 247, in wrapper
      return func(self, options, args)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/commands/install.py", line 326, in run
      session = self.get_default_session(options)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 98, in get_default_session
      self._session = self.enter_context(self._build_session(options))
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 125, in _build_session
      session = PipSession(
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/network/session.py", line 343, in __init__
      self.headers["User-Agent"] = user_agent()
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/network/session.py", line 175, in user_agent
      setuptools_dist = get_default_environment().get_distribution("setuptools")
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/__init__.py", line 75, in get_default_environment
      return select_backend().Environment.default()
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/__init__.py", line 63, in select_backend
      from . import pkg_resources
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/pkg_resources.py", line 8, in <module>
      from pip._vendor import pkg_resources
  • Updating jupyterlab-widgets (3.0.3 -> 3.0.4)
  • Updating lazy-object-proxy (1.7.1 -> 1.8.0)
  • Updating notebook (6.5.1 -> 6.5.2): Installing...
  • Updating plotly (5.10.0 -> 5.11.0): Installing...
  • Updating pycares (4.2.2 -> 4.3.0)
  • Updating pyobjc-core (8.5.1 -> 9.0): Installing...
  • Updating regex (2022.3.2 -> 2022.10.31)
  • Updating widgetsnbextension (4.0.3 -> 4.0.4): Failed

  EnvCommandError

  Command ['/Users/james/miniconda3/envs/obb/bin/pip', 'install', '--no-deps', '-U', '/Users/james/Library/Caches/pypoetry/artifacts/62/09/cd/274e73ad1110ae9cc381f10e793ccd028c87c6f098e13c443ebcdc25c2/widgetsnbextension-4.0.4-py3-none-any.whl'] errored with the following return code 2, and output: 
  ERROR: Exception:
  Traceback (most recent call last):
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 160, in exc_logging_wrapper
      status = run_func(*args)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 247, in wrapper
      return func(self, options, args)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/commands/install.py", line 326, in run
      session = self.get_default_session(options)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 98, in get_default_session
      self._session = self.enter_context(self._build_session(options))
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 125, in _build_session
      session = PipSession(
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/network/session.py", line 343, in __init__
      self.headers["User-Agent"] = user_agent()
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/network/session.py", line 175, in user_agent
      setuptools_dist = get_default_environment().get_distribution("setuptools")
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/__init__.py", line 75, in get_default_environment
      return select_backend().Environment.default()
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/__init__.py", line 63, in select_backend
      from . import pkg_resources
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/pkg_resources.py", line 8, in <module>
      from pip._vendor import pkg_resources
  • Updating jupyterlab-server (2.16.1 -> 2.16.5)
  • Updating jupyterlab-widgets (3.0.3 -> 3.0.4)
  • Updating lazy-object-proxy (1.7.1 -> 1.8.0)
  • Updating notebook (6.5.1 -> 6.5.2): Installing...
  • Updating plotly (5.10.0 -> 5.11.0): Installing...
  • Updating pycares (4.2.2 -> 4.3.0)
  • Updating pyobjc-core (8.5.1 -> 9.0): Installing...
  • Updating regex (2022.3.2 -> 2022.10.31)
  • Updating widgetsnbextension (4.0.3 -> 4.0.4): Failed

  EnvCommandError

  Command ['/Users/james/miniconda3/envs/obb/bin/pip', 'install', '--no-deps', '-U', '/Users/james/Library/Caches/pypoetry/artifacts/62/09/cd/274e73ad1110ae9cc381f10e793ccd028c87c6f098e13c443ebcdc25c2/widgetsnbextension-4.0.4-py3-none-any.whl'] errored with the following return code 2, and output: 
  ERROR: Exception:
  Traceback (most recent call last):
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 160, in exc_logging_wrapper
      status = run_func(*args)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 247, in wrapper
      return func(self, options, args)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/commands/install.py", line 326, in run
      session = self.get_default_session(options)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 98, in get_default_session
      self._session = self.enter_context(self._build_session(options))
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 125, in _build_session
      session = PipSession(
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/network/session.py", line 343, in __init__
      self.headers["User-Agent"] = user_agent()
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/network/session.py", line 175, in user_agent
      setuptools_dist = get_default_environment().get_distribution("setuptools")
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/__init__.py", line 75, in get_default_environment
      return select_backend().Environment.default()
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/__init__.py", line 63, in select_backend
      from . import pkg_resources
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/pkg_resources.py", line 8, in <module>
      from pip._vendor import pkg_resources

jmaslek avatar Dec 13 '22 00:12 jmaslek

@jmaslek we have setuptools in poetry build system. We need an older version to support building dependencies that rely on numpy image

piiq avatar Dec 13 '22 11:12 piiq

@jmaslek we have setuptools in poetry build system. We need an older version to support building dependencies that rely on numpy image

So then why does poetry remove it -- but only on certain branches?

jmaslek avatar Dec 13 '22 13:12 jmaslek

Please:

  1. Make sure that there is exception handling in place for situations when data is queried for non-popular instruments
  2. Make sure that timeouts for people who don't have twitter keys or are in networks where twitter is blocked are 1 second and less
  3. Add unit tests for every function that you have added
  1. Make sure that there is exception handling in place for situations when data is queried for non-popular instruments

What do you mean by "when data is queried for non-popular instruments"? This displays a tweet, unrelated with any instruments?

  1. Make sure that timeouts for people who don't have twitter keys or are in networks where twitter is blocked are 1 second and less
Screenshot 2022-12-13 at 14 21 58

I already had a check to disable it in case the user didn't have correct API key. The timeout I left the default one as 60s, but can do 5s instead. 👍

  1. Add unit tests for every function that you have added

Can you give me an example of what you expect the unit test for update_news_from_tweet_to_be_displayed to look like? Need to mockup the tweets of several users?

DidierRLopes avatar Dec 13 '22 14:12 DidierRLopes

Re-solved dependencies here break the dep tree and poetry can't install on a fresh env. Hold on the merge please until this is resolved

piiq avatar Dec 13 '22 15:12 piiq

https://techcrunch.com/2023/02/01/twitter-to-end-free-access-to-its-api/?guccounter=1&guce_referrer=aHR0cHM6Ly93d3cuYmluZy5jb20v&guce_referrer_sig=AQAAAIfbpM1o0f_hqTCF2yXUIeoiC3ccQaWgV2iFFqWJOffvqMdRQbVo8852Gxr578cE9oC3pd48mfMNkuFRFx2IzS0M4vF3S7HMCp1OC0bG7fnudoOMop-nyUuy2MZmAWb8NIGn6DsRGqViA6dLfEJr1Dqv0K9HeUVkH7tiekz67qCQ

jmaslek avatar Feb 02 '23 16:02 jmaslek