OpenBB icon indicating copy to clipboard operation
OpenBB copied to clipboard

#2212 Removed hist and trend comamnds from /stocks/ba

Open raviolispy opened this issue 2 years ago • 9 comments

Removing hist and trend commands from /stocks/ba as per issue Fixes #2212

Description

  • [x] Summary of the change / bug fix.
  • [x] Link # issue, if applicable.
  • [x] Screenshot of the feature or the bug before/after fix, if applicable.
  • [x] Relevant motivation and context.
  • [x] List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • [x] I have performed a self-review of my own code.
  • [x] I have commented my code, particularly in hard-to-understand areas.
  • [x] My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • [x] New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

raviolispy avatar Aug 10 '22 01:08 raviolispy

What should I do about docs @colin99d? The command has some crypto info in it but I don't see where to access it from the crypto menu.

raviolispy avatar Aug 12 '22 22:08 raviolispy

@raviolispy, sorry just saw this. I would just remove the commands from docs.

colin99d avatar Aug 18 '22 11:08 colin99d

Np @colin99d but aren't the commands supported for crypto still?

raviolispy avatar Aug 18 '22 11:08 raviolispy

Oh I thought they had duplicate versions of the docs in each, good catch. Leave them in!

colin99d avatar Aug 18 '22 11:08 colin99d

Ok so to confirm, no changes to docs?

raviolispy avatar Aug 18 '22 11:08 raviolispy

Yessir!

colin99d avatar Aug 18 '22 11:08 colin99d

@colin99d hopefully tests pass this time, can you add a label? don't think i have that ability?

raviolispy avatar Aug 20 '22 20:08 raviolispy

Just need a review and someone to add a label (or tell me how if I've missed it somewhere) please @colin99d

raviolispy avatar Aug 21 '22 19:08 raviolispy

Approved! Thanks for this PR.

colin99d avatar Aug 26 '22 16:08 colin99d