OpenBB
OpenBB copied to clipboard
#2212 Removed hist and trend comamnds from /stocks/ba
Removing hist and trend commands from /stocks/ba as per issue Fixes #2212
Description
- [x] Summary of the change / bug fix.
- [x] Link # issue, if applicable.
- [x] Screenshot of the feature or the bug before/after fix, if applicable.
- [x] Relevant motivation and context.
- [x] List any dependencies that are required for this change.
How has this been tested?
- Please describe the tests that you ran to verify your changes.
- Provide instructions so we can reproduce.
- Please also list any relevant details for your test configuration.
Checklist:
- [x] Update our Hugo documentation following these guidelines.
- [x] Update our tests following these guidelines.
- [x] Make sure you are following our CONTRIBUTING guidelines.
- [x] If a feature was added make sure to add it to the corresponding scripts file.
Others
- [x] I have performed a self-review of my own code.
- [x] I have commented my code, particularly in hard-to-understand areas.
- [x] My code passes all the checks pylint, flake8, black, ... To speed up development you should run
pre-commit install
. - [x] New and existing unit tests pass locally with my changes. You can test this locally using
pytest tests/...
.
What should I do about docs @colin99d? The command has some crypto info in it but I don't see where to access it from the crypto menu.
@raviolispy, sorry just saw this. I would just remove the commands from docs.
Np @colin99d but aren't the commands supported for crypto still?
Oh I thought they had duplicate versions of the docs in each, good catch. Leave them in!
Ok so to confirm, no changes to docs?
Yessir!
@colin99d hopefully tests pass this time, can you add a label? don't think i have that ability?
Just need a review and someone to add a label (or tell me how if I've missed it somewhere) please @colin99d
Approved! Thanks for this PR.