pika icon indicating copy to clipboard operation
pika copied to clipboard

fix: blockcache compute problem

Open Z-G-H1 opened this issue 3 weeks ago • 1 comments

#3168 share-block-cache 为yes时,多个 Column Family 共享同一个 block cache,但在统计 block cache usage 时,代码仍然对每个 CF 分别查询然后累加,导致同一个 block cache 的使用量被计算了多次。 修复前,hash,list,set 的计算均为两倍,zset为三倍: image 修复后这些数据结构的不会再被计算多次: image 添加测试: image

Z-G-H1 avatar Dec 07 '25 12:12 Z-G-H1

[!IMPORTANT]

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

[!NOTE]

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Dec 07 '25 13:12 coderabbitai[bot]

修复 CI 的部分去掉吧,一个 PR 做一件事

Done.

Z-G-H1 avatar Dec 16 '25 01:12 Z-G-H1

Bot detected the issue body's language is not English, translate it automatically.


Get rid of the part about fixing CI, one PR does one thing

Done.

Issues-translate-bot avatar Dec 16 '25 01:12 Issues-translate-bot