pika icon indicating copy to clipboard operation
pika copied to clipboard

fix: change sloglog to INFO

Open Mixficsol opened this issue 1 year ago • 1 comments

将慢日志的日志级别从 ERROR 日志调整为 INFO 日志

Summary by CodeRabbit

  • Bug Fixes
    • Adjusted logging level for slow log entries from error to informational, improving clarity in log outputs.
  • Chores
    • Updated the MacOS build step to link the existing Python installation instead of installing it directly.
    • Added installation of gcc@10 to ensure the correct compiler is available for the MacOS build.
    • Specified the C compiler path to gcc-10 in the CMake configuration for the MacOS build.

Mixficsol avatar Oct 18 '24 02:10 Mixficsol

Walkthrough

The changes in the .github/workflows/pika.yml file focus on the build_on_macos job, updating the runs-on attribute from macos-12 to macos-13. The Install Deps step has been modified to replace [email protected] with [email protected], while other dependencies like protobuf and llvm remain unchanged. The overall structure of the workflow remains intact, with no additions or deletions of jobs or steps.

Changes

File Change Summary
.github/workflows/pika.yml - Updated runs-on to macos-13 in build_on_macos job.
- Modified Install Deps to replace [email protected] with [email protected].
- Retained other dependencies like protobuf and llvm.
- No changes to other jobs or steps.

Possibly related PRs

  • #2924: The changes in the build_on_macos job in both PRs involve updates to the installation commands and step names, indicating a direct relationship in modifying the macOS build process.

🐰 In the meadow, a change took flight,
Dependencies lightened, oh what a sight!
With python updated, we hop with glee,
For smoother builds, as bright as can be!
With each little tweak, our workflow will shine,
In the world of code, everything aligns! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between ca9c71b8761382621f4f64ce87f8d31bbb86d8f7 and ef9aed8ffd7a31dd7407bfe01e05cc91a93cf003.

📒 Files selected for processing (1)
  • .github/workflows/pika.yml (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/pika.yml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Oct 18 '24 02:10 coderabbitai[bot]