qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

LED sleep + advanced layer indicators + small aggregated fixes

Open blaa opened this issue 3 years ago • 2 comments

Description

Types of Changes

  • [ ] Core
  • [x] Bugfix
  • [x] New feature
  • [ ] Enhancement/optimization
  • [ ] Keyboard (addition or update)
  • [ ] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

  • [ ] My code follows the code style of this project: C, Python
  • [ ] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

blaa avatar Sep 26 '21 21:09 blaa

Consider #49 do we still need this?

Codetector1374 avatar Oct 25 '21 23:10 Codetector1374

Idk if 49 will handle keyboard sleep, fixes carmine and has advanced indicators example. Certainly I'll remove the PoC of protocol, the compatible way is better. 49 also cherry-picked the fix to the call, so it's merged this can be skipped here.

I'll first test 49, see how it fares and then maybe update this with the rest of changes.

blaa avatar Oct 26 '21 17:10 blaa