openapi-style-validator icon indicating copy to clipboard operation
openapi-style-validator copied to clipboard

Published 20 hours ago • verified publisher icon OpenAPITools

added new api module for creating custom rules and moved error classes to new module

Open thiyagu06 opened this issue 2 years ago • 6 comments

This is the first to attempt improve the validation tool to be more extensible and customisable as discussed in https://github.com/OpenAPITools/openapi-style-validator/issues/347 and https://github.com/OpenAPITools/openapi-style-validator/pull/388. I will create series logical PR to port the existing rule validation into the new design.

thiyagu06 avatar Sep 08 '22 12:09 thiyagu06

@JFCote , I created this PR against the master branch. But I would prefer to create new branch such as V2.0 where we merge all the PR's related to this new design. Once we ported all the rules into new design, then we can merge this into master branch. Any other suggestion?

thiyagu06 avatar Sep 08 '22 12:09 thiyagu06

I will check this next week!

JFCote avatar Sep 15 '22 22:09 JFCote

@thiyagu06 I'm terribly sorry, been busy like hell these days. I didn't forget about you. Will try to check this very soon.

JFCote avatar Sep 28 '22 19:09 JFCote

@thiyagu06 I'm terribly sorry, been busy like hell these days. I didn't forget about you. Will try to check this very soon.

np @JFCote . No need to hurry. Take your time 😃

thiyagu06 avatar Sep 29 '22 07:09 thiyagu06

I created this PR against the master branch. But I would prefer to create new branch such as V2.0 where we merge all the PR's related to this new design. Once we ported all the rules into new design, then we can merge this into master branch. Any other suggestion?

Yes I think it should be against a new feature branch. Let's call it v2.0. I will create it. Can you change your PR and move it to this new branch?

JFCote avatar Oct 07 '22 12:10 JFCote

I created this PR against the master branch. But I would prefer to create new branch such as V2.0 where we merge all the PR's related to this new design. Once we ported all the rules into new design, then we can merge this into master branch. Any other suggestion?

Yes I think it should be against a new feature branch. Let's call it v2.0. I will create it. Can you change your PR and move it to this new branch?

Yes.. It's done.

thiyagu06 avatar Oct 08 '22 14:10 thiyagu06

I will look into the comments in the next week.

thiyagu06 avatar Nov 03 '22 11:11 thiyagu06

@JFCote , sorry for the delay as I held up with other things. I fixed the review comments. Let me know if we can go ahead to merge this and port all the current rule into this new structure.

thiyagu06 avatar Nov 17 '22 14:11 thiyagu06