openapi-style-validator icon indicating copy to clipboard operation
openapi-style-validator copied to clipboard

Published 20 hours ago • verified publisher icon OpenAPITools

Basic skeleton for plugging custom rules in the validation chain.

Open thiyagu06 opened this issue 2 years ago • 1 comments

This is the first to attempt improve this validation tool to be more extensible and customisable as discussed in https://github.com/OpenAPITools/openapi-style-validator/issues/347. I just created basic skeleton on how we can implement a custom rule in the existing feature. The design is inspired from the custom generator approach. The idea is at very nascent stage, we can discuss further to improve this validator to be more extensible and customisable.

thiyagu06 avatar Aug 15 '22 08:08 thiyagu06

Hi @thiyagu06 ! Thanks for this PR. Looks very interesting. I'm currently on vacation and will look closely when I get back. Thanks. In the meantime, you can check for the Lift recommandation. Also, don't worry about the build failing. It's because of Sonarqube.

JFCote avatar Aug 15 '22 17:08 JFCote

Hi @thiyagu06, please update with latest master. I have removed the sonarqube scan (too much bugs/missing features). It should build without issues now.

JFCote avatar Aug 21 '22 19:08 JFCote

Hi @JFCote ,I hope I answered most of your queries. I will try to find sometime during this week to refine more on this approach.

thiyagu06 avatar Aug 24 '22 13:08 thiyagu06

Hi @JFCote , If you feel the PR is huge and trying to do too much in a single PR. I can split into multiple logical unit and raise another PR once we agreed upon the new design. You can take a look at an sample here custom rules to see my thoughts in actions.

thiyagu06 avatar Aug 28 '22 14:08 thiyagu06

Hey @thiyagu06 , I'm back from vacation and will try to look at this in the upcoming days. Thanks

JFCote avatar Aug 31 '22 11:08 JFCote

Hi @thiyagu06 ! Sorry for the delay! I really like the design and would like that we start working towards that. I'm thinking this could take a lot of PRs and love the idea that we go step by step, assuring that nothing is broken along the way. So I guess this PR will be closed and you will start fresh?

JFCote avatar Sep 06 '22 02:09 JFCote

@JFCote , Thanks for the comments. I will think about more on how to split up the work without breaking the existing flow in coming weeks and create small logical PRs 😄 .

thiyagu06 avatar Sep 06 '22 13:09 thiyagu06