openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

#22339 fix query parameter encoding

Open Albertwaninge-2 opened this issue 1 month ago • 1 comments

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [ ] File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [ ] If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • [ ] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Albertwaninge-2 avatar Dec 08 '25 11:12 Albertwaninge-2

I had expected the generated code in samples>echo_api to be modified after runner the sample generators. But it didn't. If someone can explain why it didn't, I would like to hear it.

Albertwaninge-2 avatar Dec 08 '25 11:12 Albertwaninge-2

cc @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06) @e5l (2024/10)

wing328 avatar Dec 18 '25 08:12 wing328

thanks again for the pr

did you test this fix locally to confirm it works for your use cases?

wing328 avatar Dec 18 '25 08:12 wing328

thanks again for the pr

did you test this fix locally to confirm it works for your use cases?

Yes, I have and it is working.

Albertwaninge-2 avatar Dec 18 '25 09:12 Albertwaninge-2