[php-nextgen] Cast $weight to int in HeaderSelector::getNextWeight()

[wbohlken]

This change prevents type casting issues between float and int when multiple json accept headers can be used: Argument #2 ($weight) must be of type int, float given.

cc @jebentier @dkarlovi, @mandrean, @jfastnacht, @ybelenko, @renepardon

PR checklist

• [x] Read the contribution guidelines.
• [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• [x] Run the following to build the project and update samples:

  ./mvnw clean package || exit
  ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
  ./bin/utils/export_docs_generators.sh || exit
  

  (For Windows users, please run the script in WSL) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
• [x] File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
• [x] If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
• [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[wing328]

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

[wbohlken]

Hi @wing328,

Thanks for the quick reply, I fixed the commit and pushed again. However, the CI build seems to fail on both Linux and Windows. Do you know what causes this issue and how I can fix it?

[JulianVennen]

I think the root cause of this issue is adjustWeight which has the $currentWeight parameter annotated with a float type. This is a private method, which is only ever called with an integer value.

I think changing the parameter type of a single private method is better than changing parameter and return types of any public methods.