openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

fix: Format Date/DateTime Query Parameters in exploded, non-container Parameter

Open timgrohmann opened this issue 2 months ago • 4 comments

Fixes #22267

Tagging the committee as stated in the checklist: @TiFu @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka @joscha

Change Description

Externalise the query parameter assignment into a separate mustache script and call it in the original place as well as while setting a exploded: true, non-container param.

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [x] File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [x] If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

timgrohmann avatar Nov 02 '25 11:11 timgrohmann

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

wing328 avatar Nov 03 '25 07:11 wing328

please follow step 3 in the pr checklist to fix https://github.com/OpenAPITools/openapi-generator/actions/runs/19011794828/job/54333510734?pr=22268

wing328 avatar Nov 03 '25 08:11 wing328

Thanks for the advice @wing328, I adjusted the whitespace in the templates so the samples do not change. Also I tried correctly setting the commit author, lmk if that worked.

timgrohmann avatar Nov 03 '25 08:11 timgrohmann

Hi @wing328, friendly reminder to check this out once again.

@timgrohmann Thanks for the work! We are also running into this in one of our apps.

MikeLamsma avatar Nov 21 '25 12:11 MikeLamsma