openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[python] Validate pyproject.toml and fix the pyproject.toml version constraint format

Open 4c0n opened this issue 7 months ago • 2 comments

Fixes: https://github.com/OpenAPITools/openapi-generator/issues/21335

PR checklist

  • [X] Read the contribution guidelines.
  • [X] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [X] Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [X] File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [X] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. (@cbornet @tomplus @krjakbrjak @fa0311 @multani)

4c0n avatar Jun 10 '25 10:06 4c0n

Does anyone have any clues as to why mypy is suddenly failing? This does not seem to correlate with the changes this PR is making...

4c0n avatar Jun 13 '25 08:06 4c0n

agreed it's not related to this PR. i'll take a look

wing328 avatar Jun 16 '25 02:06 wing328

@wing328 Something like this should fix the issue: https://github.com/OpenAPITools/openapi-generator/pull/21423 it's not very pretty, but it's probably better than just excluding those lines, which would be another option (using # type: ignore).

4c0n avatar Jun 17 '25 13:06 4c0n

thanks @4c0n. just merged your fix

wing328 avatar Jun 18 '25 08:06 wing328