openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[csharp] Move RestSharp and HttpClient to their own generator

Open devhl-labs opened this issue 10 months ago • 2 comments

RestSharp and HttpClient are now moved to their own generator called csharp-restsharp. A future PR will strip generic host references from csharp-restsharp generator, and restsharp/httpclient references from the generic host generator.

@mandrean (2017/08) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05) @iBicha (2023/07)

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [x] File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

devhl-labs avatar Mar 09 '25 22:03 devhl-labs

@devhl-labs thanks for the PR

please put this on hold for the time being

wing328 avatar Mar 10 '25 05:03 wing328

@wing328 There is no rush but what is the concern?

devhl-labs avatar Mar 10 '25 06:03 devhl-labs