openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[scala][client]: scala-http4s: minor improvement (enum companion method, remove implicit, error handling)

Open JennyLeahy opened this issue 1 year ago • 1 comments

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [x] File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

JennyLeahy avatar Oct 17 '24 16:10 JennyLeahy

Please review

@clasnake @shijinkui @ramzimaalej @chameleon82 @Bouillie @fish86

JennyLeahy avatar Oct 17 '24 16:10 JennyLeahy

thanks again for the PR and took my feedback

from what I know, there's no breaking change in this PR so I'll merge it later this week

thanks for the contribution.

wing328 avatar Nov 06 '24 08:11 wing328

when you're free next week, can you please PM me to discuss the breaking change? thanks

i think i may find a way to incorporate it in the upcoming minor release (which allows breaking changes with fallback)

https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

wing328 avatar Nov 08 '24 12:11 wing328

@wing328 sorry, I missed the invitation. Could you send me the invite again? Thanks a lot

JennyLeahy avatar Nov 12 '24 17:11 JennyLeahy

please join via https://join.slack.com/t/openapi-generator/shared_invite/zt-2uoef5v0g-XGwo8~2oJ3EoziDSO1CmdQ

wing328 avatar Nov 13 '24 13:11 wing328