openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[csharp] Use HttpClientFactory for RestSharp clients

Open alec-petersen opened this issue 4 months ago • 0 comments

Still in progress on this one. Goal is to fix the following issues.

Fix #13961 Fix #14680

Currently, we create a new RestClient for every request, which also creates a new HttpClient for every request. This is known to be an issue (even if you are disposing of the client each time).

This solution adds a HttpClientFactory to cache instances of HttpClient based on BaseUrl (with a separate cache per ApiClient). Lots of considerations to take into account with this change and I'm still sifting through and accounting for the side-effects. The best solution may be to allow the user to provide an IHttpClient factory.

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [ ] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [ ] File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [ ] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

alec-petersen avatar Oct 16 '24 11:10 alec-petersen