openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

python-pydantic-v1: Handle response chartset in exception.

Open igorgatis opened this issue 1 year ago • 1 comments

This PR fixes the issue https://github.com/OpenAPITools/openapi-generator/issues/19862.

Currently, the generated code for python-pydantic-v1 tries to decode the response using utf-8. This fails when the response uses character sequence that is not utf-8, like so:

  File ".../.venv/lib/python3.11/site-packages/my_api/api_client.py", line 219, in __call_api
    e.body = e.body.decode('utf-8')
             ^^^^^^^^^^^^^^^^^^^^^^
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe7 in position 78: invalid continuation byte

This change tries to use charset from the response. It leaves content unchanged when decoding fails.

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [x] File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

igorgatis avatar Oct 14 '24 16:10 igorgatis

@fa0311 @multani

igorgatis avatar Oct 14 '24 16:10 igorgatis