openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

#1385 Generate constants for path in spring boot @RequestMapping

Open bilak opened this issue 1 year ago • 1 comments

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [x] File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg

closes #1385

bilak avatar Oct 04 '24 14:10 bilak

Hi @bilak, thanks for the PR!

Instead of introducing a new lambda "lambda.camelCaseToSnakeCase", would it work to use the already existing "lambda.snakecase"?

And could you take care of the failing tests please?

martin-mfg avatar Oct 17 '24 16:10 martin-mfg

@martin-mfg I'm not sure if I rebased somehow wrong or why 5k files is in this commit. I reverted back my custom lambda and fixed the test...let me know if I should do something additionally

bilak avatar Oct 24 '24 15:10 bilak

I've seen also this one I've tried that route but there are some issues in some codegen which I honestly don't udnerstand.

bilak avatar Oct 24 '24 15:10 bilak

@bilak Any updates on getting this merged? 🙏

elagerho avatar May 26 '25 13:05 elagerho

sorry for late review

can you please resolve the merge conflicts and i'll try to get it merged and included in the upcoming release?

wing328 avatar Jul 08 '25 03:07 wing328