openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[php] Set $multipart to true if content-type is multipart/form-data (#5536)

Open simonhammes opened this issue 1 year ago • 1 comments

The PHP client does not correctly identify multipart/form-data requests without files. See https://github.com/OpenAPITools/openapi-generator/issues/5536#issuecomment-2182344467 for details. This PR fixes this bug.

Related: https://github.com/OpenAPITools/openapi-generator/issues/5536

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [x] File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

simonhammes avatar Jun 21 '24 10:06 simonhammes

TC mentions: @jebentier @dkarlovi @mandrean @jfastnacht @ybelenko @renepardon

simonhammes avatar Jun 21 '24 10:06 simonhammes

@simonhammes thanks for the PR, which has been merged.

Sorry for taking a bit long to review.

wing328 avatar Dec 15 '24 09:12 wing328

@wing328 Thanks for merging!

Sorry for taking a bit long to review.

No worries :slightly_smiling_face:

simonhammes avatar Dec 15 '24 14:12 simonhammes