openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard
verified publisher icon OpenAPITools

make it easier to specify triggers for Zapier

Open a-wallen opened this issue 1 year ago • 2 comments

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.

closes https://github.com/OpenAPITools/openapi-generator/issues/18813

  • [x] Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh ./bin/configs/*.yaml
./bin/utils/export_docs_generators.sh
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [x] File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)

this is a non breaking change

  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@valmoz @emajo

a-wallen avatar Jun 01 '24 00:06 a-wallen

https://github.com/OpenAPITools/openapi-generator/pull/18814/commits/d2412b600d20bc676ce50065c791836963260f95 and https://github.com/OpenAPITools/openapi-generator/pull/18814/commits/049d9809bb6b7fc69681ca9f863b26b5a29ae2af should probably be dropped since they just change '/' to ''.

a-wallen avatar Jun 01 '24 00:06 a-wallen

can you please resolve the merge conflicts when you've time?

I will then try to update the samples.

wing328 avatar Jun 16 '24 02:06 wing328

@wing328 done

a-wallen avatar Jul 09 '24 20:07 a-wallen

@wing328

a-wallen avatar Sep 20 '24 15:09 a-wallen

@a-wallen sorry for the delay. I was busy with other works and just pushed an important fix to openapi-generator-cli

just reopened this PR

wing328 avatar Sep 22 '24 02:09 wing328

Just filed https://github.com/OpenAPITools/openapi-generator/pull/19638 with updated samples.

will merge if no one else has further feedback

closing this one

thanks again for the PR

wing328 avatar Sep 22 '24 06:09 wing328