openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

Fix long running test

Open Philzen opened this issue 1 year ago • 1 comments

Depending on test exec environment, this test could linger around for ~8 minutes, b/c pinging test.com will not resolve and run into several timeouts.

Brings down CI time for Linux Suite from >10m to ~4m.

Before

Connections in this test time out with

java.net.ConnectException: Connection timed out: connect

grafik grafik

After

Connection fails immediately with

java.net.ConnectException: Connection refused: connect

grafik grafik

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [ ] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [x] File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [ ] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Philzen avatar May 23 '24 21:05 Philzen

@wing328 Reviewers and contributors are going to like this :)

Unfortunately Windows and CircleCI checks are still far >10m, however this helps with time needed for local test suite execution.

Philzen avatar May 24 '24 03:05 Philzen

nice. thanks for the PR.

for windows, we can improve that with another PR later.

wing328 avatar May 25 '24 06:05 wing328

for windows, we can improve that with another PR later.

@wing328 i checked the actions' log, the test in question also fails quickly as expected there – however the total runtime of the windows actions is still high. Wondering how that could be optimized though.

Philzen avatar May 26 '24 06:05 Philzen