openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

convert all text/* content types to strings in the apache http java client

Open aaronforest-wf opened this issue 1 year ago • 3 comments

fix https://github.com/OpenAPITools/openapi-generator/issues/18730

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [x] File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

aaronforest-wf avatar May 22 '24 03:05 aaronforest-wf

Ready for review

Java Apache Http template creators: @harrywhite4 @andrevegas

Java technical committee: @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg

aaronforest-wf avatar May 22 '24 03:05 aaronforest-wf

@aaronforest-wf thanks for the PR, which looks good to me.

will merge if all tests pass.

wing328 avatar May 22 '24 12:05 wing328

Thank you @wing328!

aaronforest-wf avatar May 22 '24 16:05 aaronforest-wf