openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[java] implement #18032 add builder pattern to java client and spring generator

Open jpfinne opened this issue 9 months ago • 0 comments

Fix #18032. Add a new configOptions: generateBuilders to java client and spring generators

The name of the option is the same as in JavaJAXSRSSpecServerCodeGen.

Spring + lombok: generateBuilders + generateConstructorWithAllArgs configOptions can be used instead of lombok.

The builder is not created when lombok.Data is configured (issue with fluent setters not generated)

Improve generation of no args constructor. Also minor fix for the generateConstructorWithAllArgs and Lombok.AllArgsConstructor (there was some typos)

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [x] File the PR against the 7.0.6 (https://github.com/OpenAPITools/openapi-generator/wiki/Git-Branches): master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Please review @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08) Java Spring | @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)

jpfinne avatar May 12 '24 15:05 jpfinne