openapi-generator
openapi-generator copied to clipboard
Use Display instead of ToString in Rust generators
With the latest 1.78 release of Rust, Clippy has introduced a lint warning against the direct implementation of ToString
, recommending instead to implement Display
: https://rust-lang.github.io/rust-clippy/master/index.html#/to_string_trait_impl
This PR changes the uses of impl ToString
in the Rust generator template for impl Display
. It also updates the Rust samples. Note that because Display
has a blanket implementation of ToString
, the resulting enums will still implement ToString
, so this doesn't break anything.
Tagging openapi-generator
Rust committee, like the checklist mentions: @frol @farcaller @richardwhiuk @paladinzh @jacob-pro
PR checklist
- [x] Read the contribution guidelines.
- [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
- [x] Run the following to build the project and update samples:
(For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./mvnw clean package ./bin/generate-samples.sh ./bin/configs/*.yaml ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed. - [x] File the PR against the correct branch:
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks) - [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
thanks for the PR.
if no one else has further feedback on this change, I'll merge it over the weekend.
have a nice weekend.