openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[dart-dio] Incorrect hashCode and == overide for fields withList

Open vasilich6107 opened this issue 1 year ago • 9 comments

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [x] File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [ ] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

vasilich6107 avatar Mar 21 '24 22:03 vasilich6107

Hi @kuhnroyal I will fix the test and add the docs later today.

Just pinging you to have an overview of the fix

vasilich6107 avatar Mar 21 '24 22:03 vasilich6107

cc @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12) @ahmednfwela (2021/08)

wing328 avatar Mar 26 '24 15:03 wing328

please follow step 3 to update the samples and the docs

wing328 avatar Mar 26 '24 15:03 wing328

Hi @wing328 Will do all required steps this weekend Thanks

vasilich6107 avatar Mar 26 '24 15:03 vasilich6107

Hi @wing328 @kuhnroyal @ahmednfwela I finished the PR Sorry for delay

vasilich6107 avatar Apr 25 '24 13:04 vasilich6107

Hi @kuhnroyal This is not for freezed. it just uses different approach for equality check calculations based on utils functions from equatable library

vasilich6107 avatar Apr 26 '24 12:04 vasilich6107

Right, sorry. I meant to say for json_serializable - as this option does nothing when you select built_value as serialization library.

kuhnroyal avatar Apr 26 '24 12:04 kuhnroyal

Hi @wing328 We've finished with the PR. Could you merge it. Thanks

vasilich6107 avatar May 09 '24 09:05 vasilich6107

Hi @wing328 This Friday is a nice time to merge this awesome PR! :-)

vasilich6107 avatar May 17 '24 12:05 vasilich6107

just merged. sorry for the delay

thanks again for the PR

wing328 avatar May 19 '24 09:05 wing328

No problem. Thanks a lot for your work

vasilich6107 avatar May 19 '24 09:05 vasilich6107