openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[REQ] Update Hyper version for Rust client to use v1

Open WesleyAC opened this issue 5 months ago • 2 comments

Is your feature request related to a problem? Please describe.

The Rust client uses hyper v0.14, while v1.1.0 exists. Presumably the more modern v1 release should be used.

Describe the solution you'd like

A update to the generator to use hyper v1.

Describe alternatives you've considered

There could be a feature to allow using the newer or older hyper version, in case this is used by people still on hyper v0.14 who don't want to ship both versions.

WesleyAC avatar Feb 15 '24 21:02 WesleyAC

https://hyper.rs/guides/1/upgrading/ has a good guide to upgrading.

WesleyAC avatar Feb 15 '24 21:02 WesleyAC

There could be a feature to allow using the newer or older hyper version, in case this is used by people still on hyper v0.14 who don't want to ship both versions.

Thanks for the suggestion. I think we can go with direct upgrade without fallback to v0.14 to start with.

If there's a need (valid) later, we can create another library option (e.g. hyper-0.x)

May I know if you can contribute a PR for the upgrade? Let me know if you need help on that.

wing328 avatar Feb 16 '24 01:02 wing328

I have wanted this before as well and thought about contributing a PR, but one thing I am unclear about is the swagger crate. It would basically need to be updated in lockstep. Are you somehow involved there or know the authors?

shahn avatar Mar 04 '24 18:03 shahn