openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[JAVA][spring] #15186 Fix BeanValidation annotations on qualified types

Open tkalliom opened this issue 1 year ago • 4 comments

Fix #15186

Use a regular expression over a simple text replacement to account for the case where a qualified type is present when adding annotations to the type parameter of a collection. The test case is amended to include fields where this situation is present and for which incorrect results are produced on the current master.

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
  • [ ] In case you are adding a new generator, run the following additional script :
  • [x] File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@cachescrubber @welshm @MelleD @borsch @Zomzog

tkalliom avatar Apr 11 '23 11:04 tkalliom

Would be really great to have this in, as currently we're stuck on version 6.4.0 due to https://github.com/OpenAPITools/openapi-generator/issues/15186

rohwerj avatar Oct 12 '23 10:10 rohwerj

Hi @tkalliom Any news? this PR would be great if it could be incorporated

jorgerod avatar Feb 06 '24 15:02 jorgerod

yes, please. We also need a solution

rmenaa avatar Feb 06 '24 15:02 rmenaa

We are also experiencing this bug. Would be great to get this merged!

bushwakko avatar Apr 30 '24 08:04 bushwakko