openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

fix: escape operationIds before outputting them

Open simPod opened this issue 2 years ago • 2 comments

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [ ] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • [x] File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

The action name is escaped from ActionName to ``ActionNameOperation. The enum is also exported escaped as ActionNameOperationEnum`.

But currently, enums are then referenced via unescaped name as ActionNameEnum.

simPod avatar Jan 17 '23 16:01 simPod

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04)

simPod avatar Jan 17 '23 16:01 simPod

I tried running tests but

./mvnw clean install ends with

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.4.0:jar (attach-javadocs) on project openapi-generator-core: MavenReportException: Error while generating Javadoc: Project contains Javadoc Warnings -> [Help 1]

and IDE does not show Run test button either
image
so I kinda gave up as I don't know how to setup the project properly.

I've read contributing docs but that did not help with the issue really.

simPod avatar Jan 18 '23 09:01 simPod