openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

14432: Do not add @Valid to Java types in "jaxrs-spec" generator

Open anatoliy-balakirev opened this issue 2 years ago • 4 comments

@Valid annotation is only needed for objects, where the cascading validation is required. For standard Java types and enums it is useless. Moreover, when those annotations are there for those types - Hibernate Validator's performance degrades significantly (see: https://hibernate.atlassian.net/browse/HV-1928 and https://hibernate.atlassian.net/browse/HV-1933). I've checked other available generators, and it looks like spring generates those annotations properly. So I took the content of the modified files from that generator and placed to the jaxrs-spec one.

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • [x] File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @cachescrubber @welshm @MelleD @atextor @manedev79 @javisst @borsch @banlevente @Zomzog

anatoliy-balakirev avatar Jan 11 '23 21:01 anatoliy-balakirev

@anatoliy-balakirev can you please resolve the merge conflicts when you've time?

wing328 avatar May 16 '23 09:05 wing328

Hi @wing328. I created this PR 4 months ago and it was never reviewed ever since. I don't want to spend more time on something, which seems to be not needed, sorry. I've also switched to the Spring generator in the meanwhile. If you're interested in these changes - feel free to pick them and create your own PR.

anatoliy-balakirev avatar May 16 '23 09:05 anatoliy-balakirev

Is this still on-track for 7.0.1? Seeing some pretty horrendous performance hits with this bug, in large request bodies. The worksaround for now is to completely disable bean validation via configOptions

robinjhector avatar Sep 05 '23 11:09 robinjhector

Seems to be fixed by https://github.com/OpenAPITools/openapi-generator/pull/18302

Gerschtli avatar Jun 24 '24 12:06 Gerschtli