openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

Fix typescript codegen crash on extracting regular expression

Open wingyplus opened this issue 3 years ago • 1 comments

Fixes codegen returns error when schema has a pattern property:

Exception: Unbalanced '{' - missing '}' at
'z0-9]{3'

mention the technical committee members @TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka

Fixes #13390

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • [x] File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

wingyplus avatar Oct 10 '22 07:10 wingyplus

Here is an example of the error

  Exception: Unbalanced '{' - missing '}' at
'[0-9]{7'
      ^
        at org.openapitools.codegen.DefaultGenerator.processOperation(DefaultGenerator.java:1187)
        at org.openapitools.codegen.DefaultGenerator.processPaths(DefaultGenerator.java:1081)

The code portion that is probably causing the error:

        isrc:
          type: string
          pattern: '[a-zA-Z0-9]{5}[0-9]{7}'
          maxLength: 255

danihodovic avatar Oct 13 '22 11:10 danihodovic

Any updates on this? @wingyplus

zodiia avatar Nov 07 '22 08:11 zodiia

Could we please have an update on this? The generator is currently unusable and has been for at least the last three months (since I first reported the issue). @wingyplus @macjohnny

zodiia avatar Dec 05 '22 10:12 zodiia

Seems the author does not respond. Are you able to create a PR yourself, @zodiia ? If not, I could probably do it. Imho we should get rid of the option to have / delimiters in the patterns as it is non-standard.

bodograumann avatar Dec 05 '22 12:12 bodograumann

Seems the author does not respond. Are you able to create a PR yourself, @zodiia ? If not, I could probably do it. Imho we should get rid of the option to have / delimiters in the patterns as it is non-standard.

I'm taking a look at this, I will keep you updated ASAP.

zodiia avatar Dec 05 '22 13:12 zodiia

@bodograumann I just opened a new PR. This one should probably be closed.

zodiia avatar Dec 05 '22 14:12 zodiia

@zodiia I ran into the same issue and gave up on this client. Instead I'm using python-prior which works fine.

danihodovic avatar Dec 05 '22 16:12 danihodovic

Closing in favor of https://github.com/OpenAPITools/openapi-generator/pull/14180

macjohnny avatar Dec 05 '22 17:12 macjohnny