openapi-generator
openapi-generator copied to clipboard
OpenAPITools
Update allOf to not always be nullable
This is part of a larger PR that is being broken up. Updates allOf to not always be nullable.
To validate this change, I will focus on AllOfWithSingleRef.cs. Before the change, I edited modelGeneric.mustache to determine what properties were determining the EmitDefaultValue change by adding a /comment/ after the boolean.
...EmitDefaultValue={{#vendorExtensions.x-emit-default-value}}true /*venderExtension*/{{/vendorExtensions.x-emit-default-value}}{{^vendorExtensions.x-emit-default-value}}{{#isNullable}}true /*nullable*/{{/isNullable}}{{^isNullable}}{{#required}}true /*required*/{{/required}}{{^required}}false /*not required*/{{/required}}...
The result is that EmitDefaultValue is being determined by the property always being nullable:
After the change, we see
So we see the change makes the allOf neither required nor nullable. The input spec for this sample is modules/openapi-generator/src/test/resources/3_0/petstore-with-fake-endpoints-models-for-testing.yaml. Below is the definition for this object. It is not nullable in the spec, and it is no longer nullable in code.
PR checklist
- [x] Read the contribution guidelines.
- [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
- [x] Run the following to build the project and update samples:
Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH. - [x] File the PR against the correct branch:
master(6.1.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks) - [ ] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
