openapi-diff icon indicating copy to clipboard operation
openapi-diff copied to clipboard

Fix: BUG#348 Parameter change detection fix when path doesn't change but PathParams AND Parameters are changed (But named the same)

Open mishukdutta-toast opened this issue 3 years ago • 1 comments

  • When endpoint pathParams change and Parameter names are changed to be similar to pathParams
    • Don't remove parameters from the path
    • This allows the ChangedParameter class to not lose parameters and detect/return changes

Fixes: #353

OperationsDiff.java:
removePathParameters(context.getParameters(), params);

removes Parameters which are marked - in: path

So changes to the schema for those parameters are not detected anymore when .getParametersDiff().diff(... is run after removal

mishukdutta-toast avatar Mar 11 '22 18:03 mishukdutta-toast

tagging @joschi for visibility

mishukdutta-toast avatar Mar 14 '22 15:03 mishukdutta-toast