openaev icon indicating copy to clipboard operation
openaev copied to clipboard

[frontend] Disable buttons if contract is null

Open savacano28 opened this issue 1 year ago • 1 comments

Proposed changes

  • Manage screens when a payload is deleted (disable buttons, set the correct tag as deleted).
  • Validate if an inject has a contract.

Related issues

  • https://github.com/OpenBAS-Platform/openbas/issues/1141

Checklist

  • [x] I consider the submitted work as finished
  • [x] I tested the code for its functionality
  • [ ] I wrote test cases for the relevant uses case
  • [ ] I added/update the relevant documentation (either on github or on notion)
  • [x] Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

savacano28 avatar Jul 05 '24 12:07 savacano28

Codecov Report

Attention: Patch coverage is 14.32927% with 281 lines in your changes missing coverage. Please review.

Project coverage is 28.78%. Comparing base (8fd335b) to head (db4e3e3).

Files Patch % Lines
...io/openbas/scheduler/jobs/InjectsExecutionJob.java 0.00% 70 Missing :warning:
.../io/openbas/injectors/caldera/CalderaExecutor.java 0.00% 68 Missing :warning:
...nbas/injectors/openbas/OpenBASImplantExecutor.java 0.00% 34 Missing :warning:
...pi/src/main/java/io/openbas/utils/ResultUtils.java 0.00% 20 Missing :warning:
...c/main/java/io/openbas/service/MailingService.java 30.76% 18 Missing :warning:
...main/java/io/openbas/service/ChallengeService.java 0.00% 11 Missing :warning:
...in/java/io/openbas/rest/channel/ChannelHelper.java 65.51% 10 Missing :warning:
.../io/openbas/service/ScenarioToExerciseService.java 52.38% 9 Missing and 1 partial :warning:
...openbas/injectors/challenge/ChallengeExecutor.java 0.00% 6 Missing :warning:
.../io/openbas/injectors/channel/ChannelExecutor.java 0.00% 6 Missing :warning:
... and 10 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1193      +/-   ##
============================================
+ Coverage     28.61%   28.78%   +0.16%     
- Complexity     1279     1286       +7     
============================================
  Files           507      507              
  Lines         12964    13007      +43     
  Branches        742      736       -6     
============================================
+ Hits           3710     3744      +34     
- Misses         9096     9105       +9     
  Partials        158      158              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 08 '24 06:07 codecov[bot]