openaev icon indicating copy to clipboard operation
openaev copied to clipboard

After deleting a payload, atomic testing is throwing an error when accessing

Open SamuelHassine opened this issue 1 year ago • 5 comments

Description

image

Click on one of the list that is noted "deleted".

SamuelHassine avatar Jun 21 '24 16:06 SamuelHassine

The error message should say: "This payload has been deleted."

jborozco avatar Jun 26 '24 07:06 jborozco

@jborozco I fixed the crash, but I have some questions... when a payload is deleted, what happens in the following scenarios :

  • If an atomic testing has just this single inject, we should still allow updates to be made? (or hide button update and configure?)

Image

Image

Image

  • On the injects page for exercises, should we remove this inject from the list, or should we continue to display it?

Image

  • timeline

Image

savacano28 avatar Jun 26 '24 12:06 savacano28

I don't know how this fix has passed the review @RomuDeuxfois @Dimfacion.

First test: going to an atomic testing with a deleted payload, then clicking on configure:

image

Drawer is empty. Button should be disabled, and the screen should reflect the fact that the payload is not present anymore and this atomic testing cannot be replayed again. To be refined with @jborozco .

SamuelHassine avatar Jul 01 '24 23:07 SamuelHassine

@SamuelHassine @jborozco Sure, I pointed out the concerns initially, but the main issue was a crashing page. I thought fixing that was priority number one, and these enhancements could be another ticket also?

savacano28 avatar Jul 02 '24 07:07 savacano28

@SamuelHassine, Like @savacano28 pointed out, she told me about the issue. We thought it was more urgent to fix something crashing even if it meant having a temporary degraded version of the page. Sorry for not communicating enough on this call. Please, reach out if you feel we should handle the issue differently in the future.

Dimfacion avatar Jul 02 '24 08:07 Dimfacion

When a payload is deleted then the contract is deleted.

Results:

  • If an atomic testing is created on this payload, then we keep the previous result but we can only delete this atomic testing
  • If a scenario is created with an inject based on this payload
    • this inject will have the type deleted
    • this inject will be exported
  • If a scenario is duplicated with an inject based on this payload
    • this inject will be duplicate
  • If a simulation is created from a scenario with an inject based on this payload
    • this inject will be created
  • If a simulation is created with an inject based on this payload
    • this inject will have the type deleted
    • this inject will be exported
    • this inject wont appear in the timeline
  • If a simulation is duplicated with an inject based on this payload
    • this inject will be duplicate

RomuDeuxfois avatar Jul 23 '24 13:07 RomuDeuxfois

Exporting a scenario or a simulation with a deleted inject, then importing it -> INTERNAL ERROR

RomuDeuxfois avatar Jul 26 '24 06:07 RomuDeuxfois