PK-Sim icon indicating copy to clipboard operation
PK-Sim copied to clipboard

Allow Import/Export of BuildingBlocks to snapshot in "standard" mode

Open Yuri05 opened this issue 6 years ago • 8 comments

Currently only whole project can be exported to snapshot. Building blocks or simulations can be exported to snapshot/imported from snapshot in "developer" mode only.

For simulations it's ok and I would keep it AS IS. However I don't see any reason why we should not allow this functionality for all building blocks in the "standard" mode.

Creating/changing building block snapshots via scripting (Matlab/R) is quite easy. Allowing users importing of building block snapshots would provide additional possibilities of creating e.g. complicated administration protocols, mass data import etc.

Yuri05 avatar Aug 28 '19 12:08 Yuri05

@sfrechen @AndreDlm @InceI @tWendl FYI

Yuri05 avatar Aug 28 '19 12:08 Yuri05

As soon as we allow people to change the snapshot by hand, we have to keep in mind that they will screw up. The code is written with the assumption that the json is created only by PKSim. I would not go as far as creating a schema for the snapshot because this is A LOT OF WORK. I would simply go with the principle: Change it at your own risk

msevestre avatar Aug 28 '19 12:08 msevestre

I would not create a schema as well. Just allow Import/Export. There are quite a few use cases for this (@sfrechen @AndreDlm you might comment on this)

Yuri05 avatar Aug 28 '19 12:08 Yuri05

I think that's a very important feature - it enables e.g. the import of formulation and administration building blocks with polydisperse user-defined particle size distribution. Fully in favor of that.

AndreDlm avatar Aug 28 '19 14:08 AndreDlm

building blocks with polydisperse user-defined particle size distribution

Why can't you do it in PKSim ? Everything that is done in snapshot should be doable in PKSim no?

msevestre avatar Aug 28 '19 14:08 msevestre

Of course you can do that also in PK-Sim, but it's much easier to do this kind of stuff in an automated way outside of PK-Sim (e.g. in R) and then import the JSON file

AndreDlm avatar Aug 28 '19 15:08 AndreDlm

I don't understand but well I don't have to :)

msevestre avatar Aug 28 '19 15:08 msevestre

Sounds like a great feature!

PavelBal avatar Aug 29 '19 07:08 PavelBal