nd2reader
nd2reader copied to clipboard
Replace Deprecated np.float with np.float64 in nd2reader
Overview
This PR addresses the issue where np.float
causes an attribute error in the nd2reader package. The error is due to the deprecation of np.float
in newer versions of NumPy.
Changes
- Replaced all instances of
np.float
withnp.float64
.
Related Issues
#69 #67
Notes
- The change adheres to the recommendations found in the NumPy 1.20 release notes regarding the deprecation of
np.float
.
Thanks for this, I also encountered the same issue using a more recent version of numpy and had to implement the same fixes as yours. Hope the authors will merge and release a new version soon such that we do not need to patch the code
Is this change backward compatible with older numpy versions? If not, we should at least update the requirements https://github.com/Open-Science-Tools/nd2reader/blob/master/requirements.txt