nd2reader icon indicating copy to clipboard operation
nd2reader copied to clipboard

Replace Deprecated np.float with np.float64 in nd2reader

Open mansouralawi opened this issue 1 year ago • 2 comments

Overview

This PR addresses the issue where np.float causes an attribute error in the nd2reader package. The error is due to the deprecation of np.float in newer versions of NumPy.

Changes

  • Replaced all instances of np.float with np.float64.

Related Issues

#69 #67

Notes

  • The change adheres to the recommendations found in the NumPy 1.20 release notes regarding the deprecation of np.float.

mansouralawi avatar Nov 20 '23 14:11 mansouralawi

Thanks for this, I also encountered the same issue using a more recent version of numpy and had to implement the same fixes as yours. Hope the authors will merge and release a new version soon such that we do not need to patch the code

clementhelsens avatar Nov 29 '23 09:11 clementhelsens

Is this change backward compatible with older numpy versions? If not, we should at least update the requirements https://github.com/Open-Science-Tools/nd2reader/blob/master/requirements.txt

ggirelli avatar Feb 22 '24 13:02 ggirelli