Open-MSS
Added Python 3.12 compatibility support
Purpose of PR?:
Fixes #2738
- Updated py version pinning in
pixi.toml. - Did the setup of env. for
py3.12and also added them for ci testing - Ran test suite to check the version compatibility.
@ReimarBauer pls review this PR, also why r the ci tests here getting blocked.
This requires a tool like tox-pixi, or something similar, to set up different environments for each Python interpreter available on Conda-Forge.
Ok , got it I'll work on it , my exams are starting this week, pls assign this issue to me so that I can work on this after my exams completion on 30th
This requires a tool like tox-pixi, or something similar, to set up different environments for each Python interpreter available on Conda-Forge.
Ok , got it I'll work on it , my exams are starting this week, pls assign this issue to me so that I can work on this after my exams completion on 30th
I’d prefer to assign this or ask @matrss to work on it. You currently have over five unfinished pull requests. Leaving them open is blocking others from contributing, so please prioritize finishing those first.
This requires a tool like tox-pixi, or something similar, to set up different environments for each Python interpreter available on Conda-Forge.
Ok , got it I'll work on it , my exams are starting this week, pls assign this issue to me so that I can work on this after my exams completion on 30th
I’d prefer to assign this or ask @matrss to work on it. You currently have over five unfinished pull requests. Leaving them open is blocking others from contributing, so please prioritize finishing those first.
Sure I'll work and try to finish them asap
@ReimarBauer something like a tox-pixi (that doesn't currently exist, or do you have a link?) is not required to test against multiple python versions. Multiple different environments in pixi.toml with a corresponding python version and a matching workflow matrix using those environments would be enough. This is also assuming that we would want to test against multiple different python version now, when in the past we have only supported one reasonably up-to-date version.
@levi178u First: CI checks aren't running because you have changed pixi.toml without also changing pixi.lock. The error message also tells you as much: "Error: × lock-file not up-to-date with the workspace". Changes to dependencies always necessitate changes to the lock file, by definition. Second: your initial comment says that you have changed setup.py, when you actually haven't touched that file. This is odd. Third: your changes to the workflow file do nothing, other than running identical tests twice. You would have to actually use the matrix variables in the test jobs to differentiate them from each other.
Sorry if this sounds a bit harsh, but looking at this one and some of your other PRs I am increasingly getting the impression that you do not, yourself, understand either the issues or the changes you propose with your PRs, or both. This is concerning to me, and leads me to believe that you aren't writing these PRs yourself. Is my impression wrong or are these PRs LLM generated?
ReimarBauer something like a tox-pixi (that doesn't currently exist, or do you have a link?) is not required to test against multiple python versions. Multiple different environments in pixi.toml with a corresponding python version and a matching workflow matrix using those environments would be enough. This is also assuming that we would want to test against multiple different python version now, when in the past we have only supported one reasonably up-to-date version.
Okay, please see the link in the issue for suggestions by prefix-dev regarding potential problems this could cause.
I think we should implement a test for the next major Python version we plan to add, as older versions will eventually be removed. We don’t update to the very latest Python release, which allows us to maintain our testing strategy focused on a single Python version. The ability to use multiple Python versions is excellent.
Testing with the next Python version as early as possible will allow us to file bug reports for module versions that cause conflicts.
Since this is a recurring issue, we should address it in a straightforward manner.
The Python release cycle is accelerating. Once our dependencies on Conda-Forge are available, we need to verify if our toml/lock files work with the new version.
@ReimarBauer something like a tox-pixi (that doesn't currently exist, or do you have a link?) is not required to test against multiple python versions. Multiple different environments in pixi.toml with a corresponding python version and a matching workflow matrix using those environments would be enough. This is also assuming that we would want to test against multiple different python version now, when in the past we have only supported one reasonably up-to-date version.
@levi178u First: CI checks aren't running because you have changed pixi.toml without also changing pixi.lock. The error message also tells you as much: "Error: × lock-file not up-to-date with the workspace". Changes to dependencies always necessitate changes to the lock file, by definition. Second: your initial comment says that you have changed setup.py, when you actually haven't touched that file. This is odd. Third: your changes to the workflow file do nothing, other than running identical tests twice. You would have to actually use the matrix variables in the test jobs to differentiate them from each other.
Sorry if this sounds a bit harsh, but looking at this one and some of your other PRs I am increasingly getting the impression that you do not, yourself, understand either the issues or the changes you propose with your PRs, or both. This is concerning to me, and leads me to believe that you aren't writing these PRs yourself. Is my impression wrong or are these PRs LLM generated?
@matrss sir, I did make changes in the setup.py for python 3.12 version, my apologies i didn't recheck that before pushing, also the pixi.lock u mentioned , yes i must keep that in mind too as in the PR #2799 I got guidance to upload it too. And sir I write my PRs myself and work on them, i take reference from docs in making changes and avoid using llms. Thanks for guiding me sir, i'm a beginner so i make certain errors, my pardon but I'll work harder and do thorough checking before raising PRs.