Open-MSS
Fix: Refactored kml dockwidget for fastkml >=1.0.0
Purpose of PR?:
Fixes #2688
Changes done :
- Update fastkml KML parsing for compatibility with version >=1.0.0 and fixed issue caused by APi deprecation.
- Replaced deprecated
.from_string()usage and added encoding to ensure compatibility with fastkml 1.0.0.
@ReimarBauer when i ran the pytest for testing the kmloverlay_dockwidget.py, I got this tests/_test_msui/test_kmloverlay_dockwidget.py::Test_KmlOverlayDockWidget::test_kml_patches Fatal Python error: Aborted
what should i do to fix it and why is it occurring. I checked the files to make sure Widget is initialized before accessing its members in the test.
what should i do to fix it and why is it occurring.
Refactoring often starts with checking if the existing API is covered by tests. Then it’s about understanding what the API actually does. After that, you look at the changes in the FastKML documentation and GitHub releases. Only then can you decide how to apply the new API while maintaining functionality.
what should i do to fix it and why is it occurring.
Refactoring often starts with checking if the existing API is covered by tests. Then it’s about understanding what the API actually does. After that, you look at the changes in the FastKML documentation and GitHub releases. Only then can you decide how to apply the new API while maintaining functionality.
Ok lemme work on it
you could rebase to orgin develop
It's already based to develop branch
yours is behind.